Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-provenance in publish-commit-bottles.yml #160941

Merged

Conversation

josephsweeney
Copy link
Contributor

Adds an extra step after pr-pull in publish-commit-bottles.yml to generate build provenance for bottles that get published.

This requires a small change in Homebrew/brew to retain the temporary directory and to expose the path to the following workflow steps. This PR must be merged first before this change will work.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Adds an extra step after pr-pull in publish-commit-bottles.yml to
generate build provenance for bottles that get published.

This requires a small change in `Homebrew/brew` to retain the temporary
directory and to expose the path to the following workflow steps. That
change must be merged first before this change will work.
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Jan 25, 2024
@p-linnane p-linnane requested a review from Bo98 January 25, 2024 16:52
@josephsweeney
Copy link
Contributor Author

I will wait to mark this as ready for review until the PR mentioned above is merged.

In the meantime, if @Bo98, @carlocab, @MikeMcQuaid, @woodruffw have any feedback about testing this or the above PR, please let me know!

@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review January 26, 2024 14:02
@MikeMcQuaid MikeMcQuaid requested review from MikeMcQuaid and a team as code owners January 26, 2024 14:02
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Happy for this to be merged as-is and reverted if it causes issues.

@josephsweeney
Copy link
Contributor Author

Makes sense to me! Happy for this to be merged as-is and reverted if it causes issues.

That works for me, we'll definitely have to keep an eye out after merging on the publish-commit-bottles action but if I missed anything, it should be obvious.

Co-authored-by: Bo Anderson <mail@boanderson.me>
@carlocab
Copy link
Member

Let's try this...

@carlocab carlocab added this pull request to the merge queue Jan 27, 2024
Merged via the queue into Homebrew:master with commit 8e516dd Jan 27, 2024
19 checks passed
@carlocab
Copy link
Member

carlocab commented Jan 27, 2024

@josephsweeney
Copy link
Contributor Author

Thank you for merging @carlocab, it looks like it is working! I can see the attestation page you linked. I think that because the feature is still in early access, they haven't rolled it out to everyone yet.

@woodruffw woodruffw deleted the joesweeney/provenance-on-publish branch January 29, 2024 15:30
@woodruffw
Copy link
Member

Great work here @josephsweeney!

@carlocab: I'll see about getting you added to the private beta (along with the other org members) 🙂

@woodruffw
Copy link
Member

@carlocab You should have access to those URLs now!

(I've also asked them to add @MikeMcQuaid and @Bo98 initially -- adding everyone from the Homebrew org is manual on their side, but anybody else who wants early access can be added!)

@p-linnane
Copy link
Member

@carlocab You should have access to those URLs now!

(I've also asked them to add @MikeMcQuaid and @Bo98 initially -- adding everyone from the Homebrew org is manual on their side, but anybody else who wants early access can be added!)

Put me in coach!

@MikeMcQuaid
Copy link
Member

(I've also asked them to add @MikeMcQuaid and @Bo98 initially -- adding everyone from the Homebrew org is manual on their side, but anybody else who wants early access can be added!)

@josephsweeney Me too, please!

@josephsweeney
Copy link
Contributor Author

@MikeMcQuaid I believe you have been added. Can you see the attestations here?

@MikeMcQuaid
Copy link
Member

@josephsweeney Yup, got them now thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants