Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing SystemCommand::Mixin to fix CI #16562

Merged
merged 1 commit into from Feb 1, 2024
Merged

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Jan 31, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Should resolve https://github.com/Homebrew/brew/actions/runs/7733313670/job/21085133518

@Bo98 Bo98 merged commit b93c48e into Homebrew:master Feb 1, 2024
22 checks passed
@dduugg dduugg deleted the fix-tests branch February 1, 2024 01:33
@Bo98
Copy link
Member

Bo98 commented Feb 1, 2024

Also:

Error: undefined method `system_command' for Homebrew:Module
Do not report this issue until you've run `brew update` and tried again.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/update-sponsors.rb:64:in `update_sponsors'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:86:in `<main>'
Error: undefined method `system_command' for Homebrew:Module
Do not report this issue until you've run `brew update` and tried again.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/update-maintainers.rb:57:in `update_maintainers'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:86:in `<main>'

@dduugg
Copy link
Sponsor Member Author

dduugg commented Feb 1, 2024

Also:

Error: undefined method `system_command' for Homebrew:Module
Do not report this issue until you've run `brew update` and tried again.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/update-sponsors.rb:64:in `update_sponsors'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:86:in `<main>'
Error: undefined method `system_command' for Homebrew:Module
Do not report this issue until you've run `brew update` and tried again.
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/update-maintainers.rb:57:in `update_maintainers'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:86:in `<main>'

Yeah, there might be a long tail of these, as tests are presumably run in random orders. Since commands all live in a single namespace, sorbet can't detect which need to have the mixin, and load order determines what's been mixed in at runtime. Anyway, fix incoming.

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants