Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SystemCommand::Mixin to all commands using system_command #16566

Merged
merged 2 commits into from Feb 1, 2024

Conversation

dduugg
Copy link
Sponsor Member

@dduugg dduugg commented Feb 1, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolves #16562 (comment)

I also audited the remaining commands, since this is the second failure of this shape

cc @Bo98

@Bo98 Bo98 enabled auto-merge February 1, 2024 04:05
@Bo98 Bo98 merged commit 190563c into Homebrew:master Feb 1, 2024
22 checks passed
@dduugg dduugg deleted the fix-update-sponsors branch February 1, 2024 05:33
@MikeMcQuaid
Copy link
Member

Thanks for quick fix @dduugg and merge/review @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants