Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit taps for duplicates in aliases/renames. #16622

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Audit taps for duplicates in aliases/renames. #16622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion Library/Homebrew/tap_auditor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module Homebrew
#
# @api private
class TapAuditor
attr_reader :name, :path, :formula_names, :formula_aliases, :cask_tokens,
attr_reader :name, :path, :formula_names, :formula_aliases, :formula_renames, :cask_tokens,
:tap_audit_exceptions, :tap_style_exceptions, :tap_pypi_formula_mappings, :problems

sig { params(tap: Tap, strict: T.nilable(T::Boolean)).void }
Expand All @@ -23,6 +23,7 @@ def initialize(tap, strict:)
@formula_aliases = tap.aliases.map do |formula_alias|
formula_alias.split("/").last
end
@formula_renames = tap.formula_renames
@formula_names = tap.formula_names.map do |formula_name|
formula_name.split("/").last
end
Expand All @@ -33,6 +34,7 @@ def initialize(tap, strict:)
def audit
audit_json_files
audit_tap_formula_lists
audit_aliases_renames_duplicates
end

sig { void }
Expand All @@ -52,6 +54,14 @@ def audit_tap_formula_lists
check_formula_list "pypi_formula_mappings", @tap_pypi_formula_mappings
end

sig { void }
def audit_aliases_renames_duplicates
duplicates = formula_aliases & formula_renames.keys
return if duplicates.none?

problem "The following should either be an alias or a rename, not both: #{duplicates.to_sentence}"
end

sig { params(message: String).void }
def problem(message)
@problems << ({ message: message, location: nil, corrected: false })
Expand Down