Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit taps for duplicates in aliases/renames. #16622

Merged
merged 1 commit into from Feb 9, 2024
Merged

Audit taps for duplicates in aliases/renames. #16622

merged 1 commit into from Feb 9, 2024

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

homebrew/core currently contains some duplicates in Aliases and formula_renames.json.

@reitermarkus reitermarkus requested a review from a team February 8, 2024 15:39
ZhongRuoyu
ZhongRuoyu approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

MikeMcQuaid
MikeMcQuaid approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@reitermarkus
Copy link
Member Author

@Homebrew/core, can you check which of these should be aliases vs. renames?

https://github.com/Homebrew/brew/actions/runs/7832118805/job/21370092345?pr=16622#step:4:18

@ZhongRuoyu ZhongRuoyu mentioned this pull request Feb 9, 2024
Merged
6 tasks
@ZhongRuoyu
Copy link
Member

@Homebrew/core, can you check which of these should be aliases vs. renames?

https://github.com/Homebrew/brew/actions/runs/7832118805/job/21370092345?pr=16622#step:4:18

See Homebrew/homebrew-core#162194.

@MikeMcQuaid MikeMcQuaid merged commit 73f9869 into Homebrew:master Feb 9, 2024
24 checks passed
@scpeters scpeters mentioned this pull request Feb 12, 2024
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @ZhongRuoyu @MikeMcQuaid