Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify CaskLoader further. #16629

Merged
merged 6 commits into from Feb 12, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Feb 9, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Remove specific loaders for the default tap in favour of a single FromNameLoader.

@reitermarkus reitermarkus force-pushed the simplify-cask-loader branch 9 times, most recently from afddaa3 to 1a23206 Compare February 9, 2024 20:55
@reitermarkus reitermarkus mentioned this pull request Feb 9, 2024
7 tasks
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Again mildly concerned about potential regressions.

Library/Homebrew/cask/cask_loader.rb Outdated Show resolved Hide resolved
@reitermarkus reitermarkus merged commit a783aaf into Homebrew:master Feb 12, 2024
24 checks passed
@reitermarkus reitermarkus deleted the simplify-cask-loader branch February 12, 2024 21:03
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants