New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify tests. #16632
Simplify tests. #16632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. At a glance, it doesn't seem to increase test time noticeably and it makes the tests easier to follow. It also better insulates tests from each other by clearing the tap caches.
# These are only used manually in tests since they | ||
# would otherwise conflict with other casks. | ||
next if relative_cask_path.dirname.basename.to_s == "outdated" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could just include this in the glob pattern itself. Doesn't need to be changed though. This is fine.
This may be causing some |
Interesting... I wouldn't expect this to affect the linter at all since the only things that have changed here are tests and fixtures. I'll look into it some more but also we could just revert this since it's just a refactor. |
This is very much a best guess on my end for which recent PR changed this behavior. I don't think it's affecting enough stuff to revert, since that one instance is all I've seen having issues. If we can fix forward that'd be even better! |
It seems that there exists a handbrake cask as well and that's getting linted here for no reason. It'd probably be good to fix the test bot so that it only runs then audit on formulae here as well. But that doesn't really solve the root of the problem, just the symptom. |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Extracted from #16629 to see if any of these changes cause the flaky tests.