Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops/resource_requires_dependencies: check sym_type? #17035

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 5, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Previous behavior shouldn't impact expected DSL usage; however, in the case of some incorrect DSL brew audit will output a message like:

An error occurred while FormulaAudit/ResourceRequiresDependencies cop was inspecting ...
Errors are usually caused by RuboCop bugs.
Please, report your problems to RuboCop's issue tracker.

To avoid incorrectly directing users to RuboCop repo, I am following up on #17032 to only operate after filtering the sym_type?

Avoid running `#value` on unsupported types by selecting only symbol
nodes as we only care about `:build` value.

Signed-off-by: Michael Cho <michael@michaelcho.dev>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit dcf80b6 into Homebrew:master Apr 5, 2024
25 checks passed
@cho-m cho-m deleted the resource_requires_dependencies-avoid-stacktrace branch April 5, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants