rubocops/resource_requires_dependencies: allow lxml
build resource
#17032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, a
lxml
build resource can depend on build-onlylibxml2
andlibxslt
; however, these were not detected in previous audit since the dependency would be a hash.Also change message if Linux-only formula.
These changes are both needed for
systemd
.brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This isn't able to handle situation of detecting build-only vs runtime usage of resource. Most likely won't be easily able to do this without extending DSL to annotate this information
However, in the scenario where a build dependency should actually be runtime, our linkage audits should catch it (though won't be a hard failure in case of indirect dependency).