Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Tab.for_keg and use Keg#tab where possible. #17168

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Apr 28, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@carlocab
Copy link
Member

Keg#tab just calls Tab.for_keg so I'm not sure why you would prefer Keg#tab over Tab.for_keg.

@reitermarkus
Copy link
Member Author

Because it's shorter.

@reitermarkus
Copy link
Member Author

Also, to better keep track of where Tab.for_keg is still called with a Pathname, so we can eventually change it to only take Kegs.

@reitermarkus reitermarkus force-pushed the tab-for-keg branch 8 times, most recently from 7084afc to 0b56d0b Compare April 28, 2024 18:50
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit db22da9 into Homebrew:master Apr 29, 2024
32 checks passed
@reitermarkus reitermarkus deleted the tab-for-keg branch April 29, 2024 19:54
ZhongRuoyu added a commit that referenced this pull request May 1, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label May 30, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants