Curl#curl_headers: Work with 8 exit_status #17412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Bo98
reviewed
Jun 3, 2024
MikeMcQuaid
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Looks good! Agreed on @Bo98's comment and good to merge after that.
Might be an idea to make the 8 and 22 here constants in this file so the code is a bit more self-documenting.
samford
force-pushed
the
curl-work-with-8-exit_status
branch
from
9774cec
to
f511ea6
Compare
|
Updated to add constants for these curl exit status codes, using the names from |
MikeMcQuaid
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Looking good @samford! Just some suggested style/name changes.
I recently noticed that ~23 `livecheck` blocks using the `HeaderMatch`
strategy were failing. Looking into it, these fail when using a `HEAD`
request and retry with `GET` but the resulting response with the
headers we want is simply discarded because the `exit_status` from
curl is 8 ("weird server reply").
This resolves the issue by adding a special case for this exit status,
so `#curl_headers` will return the headers in this scenario.
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
samford
force-pushed
the
curl-work-with-8-exit_status
branch
from
f511ea6
to
8236a70
Compare
carlocab
approved these changes
Jun 4, 2024
MikeMcQuaid
approved these changes
Jun 4, 2024
|
Thanks again @samford! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?I recently noticed that ~23
livecheckblocks using theHeaderMatchstrategy were failing. Looking into it, these fail when using aHEADrequest and retry withGETbut the resulting response with the headers we want is simply discarded because theexit_statusfrom curl is 8 ("weird server reply").This resolves the issue by adding a special case for this exit status, so
#curl_headerswill return the headers in this scenario.