Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl#curl_headers: Work with 8 exit_status #17412

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Curl#curl_headers: Work with 8 exit_status #17412

merged 2 commits into from
Jun 4, 2024

Commits on Jun 4, 2024

  1. Curl#curl_headers: Work with 8 exit_status 

    I recently noticed that ~23 `livecheck` blocks using the `HeaderMatch`
strategy were failing. Looking into it, these fail when using a `HEAD`
request and retry with `GET` but the resulting response with the
headers we want is simply discarded because the `exit_status` from
curl is 8 ("weird server reply").

This resolves the issue by adding a special case for this exit status,
so `#curl_headers` will return the headers in this scenario.
    @samford
    samford committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d3eac38 View commit details
    Browse the repository at this point in the history

  2. Curl: Add constants for used curl errors 

    Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
    @samford @MikeMcQuaid
    samford and MikeMcQuaid committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    8236a70 View commit details
    Browse the repository at this point in the history