keg: fix fallback dependencies with multiple kegs #1752
Conversation
| f.installed_kegs.any? { |k| Tab.for_keg(k).runtime_dependencies.nil? } | ||
| installed_kegs = f.installed_kegs | ||
|
|
||
| # All installed kegs are going to be removed anyway, |
There was a problem hiding this comment.
Can you elaborate a bit more on this? The "removed anyway" bit makes sense in context of the PR but I'm not sure it does in the context of the function itself which isn't necessarily relating specifically to uninstall.
There was a problem hiding this comment.
Sure. The purpose of Keg.find_some_installed_dependents is to take some kegs and see if there are any kegs outside of that array that depend on those kegs. (That's why it takes an array.) This is what it does currently when the install receipts are reliable.
But, in the fallback, I forgot to remove the passed kegs from the list of dependents, so now I've fixed that.
There was a problem hiding this comment.
Cool, makes sense. I think the comment could be expanded on a bit to make this clearer e.g. why they will be "removed"
alyssais
force-pushed
the
uninstalling_dependencies
branch
from
343edd8
to
b0a38c0
Compare
|
Perfect. Great comments. |
|
Thanks @alyssais! |
brew testswith your changes locally?We didn't remove formulae to be uninstalled from the list of installed formulae to check for dependencies, but only in the fallback. This is what caused #1524, and made it difficult to reproduce (because one had to realise that it was only in the fallback).