Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask: ignore minimum macOS in on_os blocks for variations #17540

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The fixes I made for variations generation in #17386 didn't account for when depends_on macos: is called inside an on_os block. Affected casks are set to be fixed in Homebrew/homebrew-cask#176710; until then, any cask with a minimum macOS set anywhere will not show versions older than that.

For example, macupdater is shown as requiring Ventura despite defining an older version in an on_monterey :or_older block.

It was recently pointed out that this causes affected casks to be incorrectly shown as upgradeable on older systems.

This PR revises the variations generation fix to ignore depends_on stanzas that are set within on_os blocks. This'll briefly bring back some of the issues with formulae.brew.sh pages until the affected casks are fixed.

@EricFromCanada EricFromCanada requested a review from Bo98 June 21, 2024 03:35
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Bo98 Bo98 merged commit fd04d88 into master Jun 21, 2024
25 checks passed
@Bo98 Bo98 deleted the on_os-depends_on branch June 21, 2024 03:55
@MikeMcQuaid
Copy link
Member

Thanks @EricFromCanada!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants