cask: ignore minimum macOS in on_os blocks for variations #17540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?The fixes I made for variations generation in #17386 didn't account for when
depends_on macos:
is called inside an on_os block. Affected casks are set to be fixed in Homebrew/homebrew-cask#176710; until then, any cask with a minimum macOS set anywhere will not show versions older than that.For example, macupdater is shown as requiring Ventura despite defining an older version in an
on_monterey :or_older
block.It was recently pointed out that this causes affected casks to be incorrectly shown as upgradeable on older systems.
This PR revises the variations generation fix to ignore
depends_on
stanzas that are set within on_os blocks. This'll briefly bring back some of the issues with formulae.brew.sh pages until the affected casks are fixed.