various casks: fix macOS version requirements

[EricFromCanada]

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

• The submission is for a stable version or documented exception.
• brew audit --cask --online <cask> is error-free.
• brew style --fix <cask> reports no offenses.

---

• removes minimum macOS version requirements that were preventing installations on older versions
• consolidates on_system-specific macOS version requirements to a single declaration for the cask, allowing its formulae.brew.sh entry to display all available versions

[bevanjkay]

consolidates on_system-specific macOS version requirements to a single declaration for the cask, allowing its formulae.brew.sh entry to display all available versions

I'm not sure how well this will work thinking future-forward. There is an audit that is currently for new casks only (or with the --strict) flag that compares the app's info.plist file with what we have, so these will likely fail the audit if there is a mismatch. There's potential for this audit to be applied to existing casks in future.

[bevanjkay]

brew audit --online airfoil --new

audit for airfoil: failed
 - Upstream defined :sonoma as the minimum OS version and the cask defined :big_sur

[Bo98]

these will likely fail the audit

That's definitely an audit bug/shortcoming. It should be smarter and check if it's in an on_os block (and if the range of that block is correct).

[EricFromCanada]

With Homebrew/brew#17548 merged, cask/audit.rb now prioritizes on_os block declarations over depends_on, which should address the above concerns.

[krehel]

Makes a lot of sense @EricFromCanada. Thanks for taking this on and doing some heavy lifting. I'm good here!