Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure early installation of gh for attestations #17760

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Ensure early installation of gh for attestations #17760

merged 8 commits into from
Jul 17, 2024

Conversation

nandahkrishna
Copy link
Member

@nandahkrishna nandahkrishna commented Jul 15, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR fixes installing a suitable gh for attestations. We now install gh before any other formula installation if attestations are enabled.

Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nandahkrishna nandahkrishna merged commit 321498c into master Jul 17, 2024
24 checks passed
@nandahkrishna nandahkrishna deleted the gh-fix branch July 17, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants