Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/git: cache less aggressively. #3206

Merged
merged 1 commit into from
Sep 24, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Library/Homebrew/utils/git.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ def last_revision_of_file(repo, file, before_commit: nil)

module Utils
def self.git_available?
return @git if instance_variable_defined?(:@git)
@git = quiet_system HOMEBREW_SHIMS_PATH/"scm/git", "--version"
@git ||= quiet_system HOMEBREW_SHIMS_PATH/"scm/git", "--version"
end

def self.git_path
Expand Down Expand Up @@ -58,12 +57,11 @@ def self.ensure_git_installed!
end
end

clear_git_available_cache
raise "Git is unavailable" unless git_available?
end

def self.clear_git_available_cache
remove_instance_variable(:@git) if instance_variable_defined?(:@git)
@git = nil
@git_path = nil
@git_version = nil
end
Expand Down