New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_environment: add Linux-specific environment variables #3358

Merged
merged 1 commit into from Oct 24, 2017

Conversation

Projects
None yet
2 participants
@maxim-belkin
Contributor

maxim-belkin commented Oct 23, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

supersedes #3341

Add Linux-specific environment variables to build_env_keys method:

  • LD_LIBRARY_PATH
  • LD_RUN_PATH
  • LD_PRELOAD
  • LIBRARY_PATH

CC @sjackman @MikeMcQuaid

@maxim-belkin maxim-belkin referenced this pull request Oct 23, 2017

Closed

build-environment: OS-specific environment keys #3341

3 of 5 tasks complete

@maxim-belkin maxim-belkin changed the title from build_environment: add Linux environment variables to build_environment: add Linux-specific environment variables Oct 23, 2017

@MikeMcQuaid MikeMcQuaid merged commit d5e3230 into Homebrew:master Oct 24, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 357b7bb...7000585
Details
codecov/project 67.25% (+0.17%) compared to 357b7bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MikeMcQuaid

This comment has been minimized.

Show comment
Hide comment
@MikeMcQuaid

MikeMcQuaid Oct 24, 2017

Member

Thanks again @maxim-belkin (and @sjackman for input)

Member

MikeMcQuaid commented Oct 24, 2017

Thanks again @maxim-belkin (and @sjackman for input)

@maxim-belkin maxim-belkin deleted the maxim-belkin:build-env2 branch Oct 24, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.