New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xcode 9.1 Updates. #3409
Xcode 9.1 Updates. #3409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this about a week before merging.
🌮 |
Oh, okay. I meant 👍 but I guess 🌮 will do too. |
CC @sjackman time to start bugging Circle CI again ;) |
Thanks for the heads up. No mention of 9.1 yet on CircleCI. Here's where it will be listed: https://circleci.com/docs/1.0/build-image-macos/#selecting-xcode-version-and-operating-system |
This says 9.1 is available: https://discuss.circleci.com/t/xcode-9-1-release-for-circleci-2-0/17891 |
high_sierra_homebrew_1, high_sierra_homebrew_2, and high_sierra_homebrew_3 don't have 9.1, which is unfortunate, but since we're not using those very often right now I don't think that has to block this PR. |
Thanks @ilovezfs 🙇 |
brew tests
with your changes locally?