Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 9.1 Updates. #3409

Merged
merged 3 commits into from Nov 7, 2017
Merged

Xcode 9.1 Updates. #3409

merged 3 commits into from Nov 7, 2017

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Nov 1, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

Copy link
Contributor

@ilovezfs ilovezfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this about a week before merging.

@DomT4
Copy link
Member Author

DomT4 commented Nov 1, 2017

🌮

@DomT4
Copy link
Member Author

DomT4 commented Nov 1, 2017

Oh, okay. I meant 👍 but I guess 🌮 will do too.

@ilovezfs
Copy link
Contributor

ilovezfs commented Nov 1, 2017

CC @sjackman time to start bugging Circle CI again ;)

@sjackman
Copy link
Member

sjackman commented Nov 1, 2017

Thanks for the heads up. No mention of 9.1 yet on CircleCI. Here's where it will be listed: https://circleci.com/docs/1.0/build-image-macos/#selecting-xcode-version-and-operating-system

@ilovezfs
Copy link
Contributor

ilovezfs commented Nov 7, 2017

@ilovezfs
Copy link
Contributor

ilovezfs commented Nov 7, 2017

high_sierra_homebrew_1, high_sierra_homebrew_2, and high_sierra_homebrew_3 don't have 9.1, which is unfortunate, but since we're not using those very often right now I don't think that has to block this PR.

@ilovezfs ilovezfs merged commit 4cc72cf into Homebrew:master Nov 7, 2017
@DomT4 DomT4 deleted the xcode branch November 7, 2017 09:22
@DomT4
Copy link
Member Author

DomT4 commented Nov 7, 2017

Thanks @ilovezfs 🙇

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants