New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 9.1 Updates. #3409

Merged
merged 3 commits into from Nov 7, 2017

Conversation

Projects
None yet
3 participants
@DomT4
Contributor

DomT4 commented Nov 1, 2017

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew tests with your changes locally?

DomT4 added some commits Nov 1, 2017

@ilovezfs

Let's give this about a week before merging.

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Nov 1, 2017

Contributor

🌮

Contributor

DomT4 commented Nov 1, 2017

🌮

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Nov 1, 2017

Contributor

Oh, okay. I meant 👍 but I guess 🌮 will do too.

Contributor

DomT4 commented Nov 1, 2017

Oh, okay. I meant 👍 but I guess 🌮 will do too.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Nov 1, 2017

Contributor

CC @sjackman time to start bugging Circle CI again ;)

Contributor

ilovezfs commented Nov 1, 2017

CC @sjackman time to start bugging Circle CI again ;)

@sjackman

This comment has been minimized.

Show comment
Hide comment
@sjackman

sjackman Nov 1, 2017

Contributor

Thanks for the heads up. No mention of 9.1 yet on CircleCI. Here's where it will be listed: https://circleci.com/docs/1.0/build-image-macos/#selecting-xcode-version-and-operating-system

Contributor

sjackman commented Nov 1, 2017

Thanks for the heads up. No mention of 9.1 yet on CircleCI. Here's where it will be listed: https://circleci.com/docs/1.0/build-image-macos/#selecting-xcode-version-and-operating-system

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs
Contributor

ilovezfs commented Nov 7, 2017

@ilovezfs ilovezfs removed the do not merge label Nov 7, 2017

.

@ilovezfs

This comment has been minimized.

Show comment
Hide comment
@ilovezfs

ilovezfs Nov 7, 2017

Contributor

high_sierra_homebrew_1, high_sierra_homebrew_2, and high_sierra_homebrew_3 don't have 9.1, which is unfortunate, but since we're not using those very often right now I don't think that has to block this PR.

Contributor

ilovezfs commented Nov 7, 2017

high_sierra_homebrew_1, high_sierra_homebrew_2, and high_sierra_homebrew_3 don't have 9.1, which is unfortunate, but since we're not using those very often right now I don't think that has to block this PR.

@ilovezfs ilovezfs merged commit 4cc72cf into Homebrew:master Nov 7, 2017

2 of 3 checks passed

codecov/patch 0% of diff hit (target 68.17%)
Details
codecov/project 68.57% (+0.4%) compared to 302bc8b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DomT4 DomT4 deleted the DomT4:xcode branch Nov 7, 2017

@DomT4

This comment has been minimized.

Show comment
Hide comment
@DomT4

DomT4 Nov 7, 2017

Contributor

Thanks @ilovezfs 🙇

Contributor

DomT4 commented Nov 7, 2017

Thanks @ilovezfs 🙇

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.