docs: remove :python requirement #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssais
reviewed
Jan 12, 2018
docs/Homebrew-and-Python.md
Outdated
| @@ -89,4 +89,4 @@ Homebrew will still install Python modules into Homebrew's `site-packages` and * | |||
| Virtualenv has a `--system-site-packages` switch to allow "global" (i.e. Homebrew's) `site-packages` to be accessible from within the virtualenv. | |||
|
|
|||
| ## Why is Homebrew's Python being installed as a dependency? | |||
| Formulae that depend on the special `:python` target are bottled against the Homebrew Python and require it to be installed. You can avoid installing Homebrew's Python by building these formulae with `--build-from-source`. | |||
| Formulae that declare an unconditional dependency on the `"python"` or `"python3"` formulae are bottled against Homebrew's Python 2.7.x or 3.x and require it to be installed. You can avoid installing Homebrew's Python by running `brew install --build-from-source <formula>`. | |||
There was a problem hiding this comment.
I’m not sure this is right. I’m pretty sure you can’t skip building python for a formula that unconditionally depends_on “python”
MikeMcQuaid
approved these changes
Jan 12, 2018
There was a problem hiding this comment.
Made some tweaks but good to go now. Thanks again @EricFromCanada, you rock!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew testswith your changes locally?Replace references to the
:pythonrequirement with the"python"formula in the docs, as per Homebrew/homebrew-core#22703.