bump-formula-pr: more enhancements. #3729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Jan 24, 2018
| base_url = if new_url_split.count > 5 | ||
| new_url_split[0..4].join("/") | ||
| else | ||
| new_url_split[0..(new_url_split.count - 2)].join("/") |
There was a problem hiding this comment.
With all these splits a comment would be cool explaining what's going on here (as I have no idea). Perhaps using some/a new variables for the 5, 4, new_url_split.count - 2?
| new_mirror | ||
| else | ||
| new_url | ||
| new_mirror = if requested_spec != :devel && new_url =~ %r{.*ftp.gnu.org/gnu.*} |
There was a problem hiding this comment.
Could maybe make this a case statement if you anticipate more of these in future.
alyssais
approved these changes
Jan 24, 2018
| @@ -260,7 +264,7 @@ def bump_formula_pr | |||
| end | |||
| elsif forced_version && forced_version == "0" | |||
| if requested_spec == :stable | |||
| replacement_pairs << [/^ version \"[a-z\d+\.]+\"\n/m, ""] | |||
| replacement_pairs << [/^ version \"[a-zA-Z\d+\.\-\_]+\"\n/m, ""] | |||
There was a problem hiding this comment.
Could be shortened to this, I think:
/^ version \"[\w\.\-]+\"\n/m
4 tasks
homebrew/core now uses ftp.gnu.org/gnu for the primary url and ftpmirror.gnu.org for the mirror.
Previously, CurlDownloadStrategy was hard coded.
ilovezfs
force-pushed
the
bump-formula-pr-more-enhancements
branch
from
6f6313c
to
ccbe494
Compare
|
PR refreshed. |
MikeMcQuaid
approved these changes
Jan 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?