Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move linkage_checker from os/mac to generic #3852

Merged
merged 1 commit into from
Mar 1, 2018

Conversation

sjackman
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Move check_linkage from os/mac/formula_cellar_checks to generic.

@sjackman
Copy link
Member Author

I'm working on fixing the test failures.

@sjackman
Copy link
Member Author

Done.

@alyssais alyssais merged commit 43c658a into Homebrew:master Mar 1, 2018
@sjackman sjackman deleted the linkage_checker branch March 1, 2018 18:01
@sjackman
Copy link
Member Author

sjackman commented Mar 1, 2018

Thanks for merging, Alyssa!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants