Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language/python, docs: updates for python 3.7 #4406

Merged
merged 3 commits into from
Jul 10, 2018
Merged

language/python, docs: updates for python 3.7 #4406

merged 3 commits into from
Jul 10, 2018

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Jul 2, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@commitay commitay added the python Homebrew/brew's python support label Jul 2, 2018
@ghost ghost assigned commitay Jul 2, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 2, 2018
ilovezfs
ilovezfs reviewed Jul 2, 2018
View reviewed changes
docs/Homebrew-and-Python.md Outdated
@@ -51,12 +51,12 @@ The `site-packages` is a directory that contains Python modules (especially bind
$(brew --prefix)/lib/pythonX.Y/site-packages
```

So, for Python 3.6.x, you'll find it at `/usr/local/lib/python3.6/site-packages`.
So, for Python 3.x.x, you'll find it at `/usr/local/lib/python3.x/site-packages`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x.x seems a bit off since those values aren't necessarily the same

@ilovezfs ilovezfs merged commit 0aab25b into Homebrew:master Jul 10, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jul 10, 2018
@ilovezfs
Copy link
Contributor

🐍 Thanks @commitay

@commitay commitay deleted the python-3.7 branch July 10, 2018 09:14
@commitay commitay removed their assignment Jul 10, 2018
@lock lock bot added the outdated PR was locked due to age label Aug 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilovezfs ilovezfs ilovezfs left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age python Homebrew/brew's python support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@commitay @ilovezfs @MikeMcQuaid