Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t expand executable path in SystemCommand. #4469

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Otherwise plain executable names would be expanded to $PWD/executable instead of looking for it in the PATH.

@ghost ghost assigned reitermarkus Jul 14, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 14, 2018
@commitay
Copy link
Contributor

What happened to @homebrew/cask for reviews?

@MikeMcQuaid
Copy link
Member

@commitay https://blog.github.com/2017-07-06-introducing-code-owners/ may be of interest

@commitay
Copy link
Contributor

Yes, that might be useful but why was the option for the homebrew/cask team to review a PR removed?

@MikeMcQuaid MikeMcQuaid removed the request for review from vitorgalvao July 14, 2018 08:58
@MikeMcQuaid
Copy link
Member

@commitay It wasn't? I can't add it either but there certainly wasn't any action there that changed things.

@commitay
Copy link
Contributor

Weird, it was working a few days ago, the read-only access for the cask team has been removed for this repo. Should it be restored or do we want to go with CODEOWNERS?

@MikeMcQuaid
Copy link
Member

@commitay Weird that read-only on a public repo has that effect! Fixed now, thanks for pointing it out 🙇

@reitermarkus reitermarkus merged commit b7e8497 into Homebrew:master Jul 14, 2018
@reitermarkus reitermarkus deleted the systemcommand-path branch July 14, 2018 20:45
@ghost ghost removed the in progress Maintainers are working on this label Jul 14, 2018
@commitay
Copy link
Contributor

Thanks @MikeMcQuaid ❤️

@lock lock bot added the outdated PR was locked due to age label Aug 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants