Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_config: add HOMEBREW_MACOS_VERSION_NUMERIC to boring_keys #4967

Merged
merged 1 commit into from
Sep 23, 2018
Merged

system_config: add HOMEBREW_MACOS_VERSION_NUMERIC to boring_keys #4967

merged 1 commit into from
Sep 23, 2018

Conversation

commitay
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow up to #4952

@ghost ghost assigned commitay Sep 23, 2018
@ghost ghost added the in progress Maintainers are working on this label Sep 23, 2018
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, sorry for missing this, thanks @commitay!

@MikeMcQuaid MikeMcQuaid merged commit 144949d into Homebrew:master Sep 23, 2018
@ghost ghost removed the in progress Maintainers are working on this label Sep 23, 2018
@commitay commitay deleted the boring_keys branch September 23, 2018 08:25
@commitay commitay removed their assignment Sep 23, 2018
@lock lock bot added the outdated PR was locked due to age label Oct 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants