bottles: make or_later the default.

[MikeMcQuaid]

When Mojave was in beta we made it so that High Sierra bottles would automatically be used on Mojave. Let's make this the default in general: older bottles will be used on newer versions of macOS when a newer bottle is not available.

This should make it easier for taps to bottle single versions of bottles which will work more widely and to give us breathing room whenever a new version of macOS is released.

Currently this only applies to the wine formula which will have the or_later removed in a Homebrew/homebrew-core PR.

Question: should we use an odeprecated for the use of or_later?

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

[scpeters]

A nice thing about or_later is that it is semantically clear, but if we document the behavior well enough, then I think we could get rid of it

[fxcoudert]

I agree: or_later gives us a nice way to distinguish, in theory, the formulas where we don't provide a bottle because we haven't managed to yet, and those where it is actually impossible to do so (such as wine). I don't know if that difference is important enough to retain, but I thought I would mention it.

[scpeters]

I think there's a fair bit of overlap between MaximumMacOSRequirement and the or_later bottle tag, no?

[MikeMcQuaid]

A nice thing about or_later is that it is semantically clear, but if we document the behavior well enough, then I think we could get rid of it

The main issue is that it's not handled on updates in brew pull or brew test-bot. I was going to handle that but then remembered what we did (successfully) with Mojave and figured that was a sensible default that will make life easier for both us in future and taps.

I agree: or_later gives us a nice way to distinguish, in theory, the formulas where we don't provide a bottle because we haven't managed to yet, and those where it is actually impossible to do so (such as wine). I don't know if that difference is important enough to retain, but I thought I would mention it.

Good point 👍. I think we can achieve that with a comment for now (like you've been doing with the Python migration).

I think there's a fair bit of overlap between MaximumMacOSRequirement and the or_later bottle tag, no?

Yeh, there is. Arguably there need not be unless the bottle is also broken. I need to test whether MaximumMacOSRequirement works nicely as a :build requirement in which case that could be used to indicate "the bottle works fine but the non-bottle install does not".

[MikeMcQuaid]

I need to test whether MaximumMacOSRequirement works nicely as a :build requirement in which case that could be used to indicate "the bottle works fine but the non-bottle install does not".

It didn't but I'm fixing it in #5101

[sjackman]

Excellent! I've been using _or_later in Brewsci/bio for macOS. This is better.