Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: Use CLI::Parser to parse args #5201

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

GauthamGoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#1860

@GauthamGoli
Copy link
Contributor Author

--build-bottle wasn't in the documentation. Are there any other such options that brew fetch accepts?

@MikeMcQuaid
Copy link
Member

@GauthamGoli Also --build-from-source. In general probably any arguments accepted by brew install so it may be worth leaving until others are done first.

@stale
Copy link

stale bot commented Nov 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Nov 18, 2018
@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label Nov 18, 2018
@stale stale bot removed the stale No recent activity label Nov 18, 2018
@MikeMcQuaid
Copy link
Member

@GauthamGoli From looking at #5619 I think the ones that need added are: --build-from-source, --force-bottle, --build-bottle and that should be everything.

@MikeMcQuaid MikeMcQuaid merged commit 3bdc4c2 into Homebrew:master Jan 29, 2019
@lock lock bot added the outdated PR was locked due to age label Feb 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress Maintainers are working on this outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants