install: Use CLI::Parser to parse args

[GauthamGoli]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

#1860

[MikeMcQuaid]

Might be a good idea to use the build_options.invalid_option_names above instead of the formulae loop?

[GauthamGoli]

Sorry, I'm not sure I understand. Can you explain this more?

[MikeMcQuaid]

Sure. This is used at

brew/Library/Homebrew/formula_installer.rb

Lines 270 to 272 in 0670282

	invalid_option_names.each do |option|
	opoo "#{formula.full_name}: this formula has no #{option} option so it will be ignored!"
	end

so will never fire in future if this is added (so could be deleted). Given build_options.invalid_option_names already exists perhaps that method could be used instead, used for inspiration (or deleted):

brew/Library/Homebrew/build_options.rb

Lines 102 to 116 in 0670282

	# @private
	def invalid_options
	@args - @options - BuildOptions.formula_install_options
	end
	# @private
	def invalid_option_names
	invalid_options.map(&:flag).sort
	end
	def self.formula_install_options
	@formula_install_options ||= ARGV.formula_install_option_names.map do |option_name|
	Option.new option_name[2..-1]
	end
	end

Make sense?

[GauthamGoli]

Thanks @MikeMcQuaid. Got it.

One more question.

In the existing behaviour, we ignore the invalid options passed, but that is not possible with OptionParser, as we only declare the valid options. Do we ideally want to preserve this functionality?

[MikeMcQuaid]

@GauthamGoli If we're only looking at externally passed options I think it's fine/better to error out rather than ignoring and messaging 👍

[MikeMcQuaid]

Would be good to use/replace this logic:

brew/Library/Homebrew/formula_installer.rb

Lines 270 to 272 in 0670282

	invalid_option_names.each do |option|
	opoo "#{formula.full_name}: this formula has no #{option} option so it will be ignored!"
	end