Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch: Use CLI::Parser to parse args #5559

Merged
merged 2 commits into from
Jan 20, 2019

Conversation

GauthamGoli
Copy link
Contributor

@GauthamGoli GauthamGoli commented Jan 18, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#1860

@GauthamGoli GauthamGoli changed the title switch: Use CLI::Parser to parse args [WIP] switch: Use CLI::Parser to parse args Jan 18, 2019
@GauthamGoli
Copy link
Contributor Author

Need to declare

switch :verbose
switch :debug

but the command itself is switch ,
@MikeMcQuaid Any workaround?

@MikeMcQuaid
Copy link
Member

@GauthamGoli I think if you fully scope the module/class you may be able to get it working. Alternatively, consider adding aliases to the switch method so you can call something else.

@GauthamGoli GauthamGoli changed the title [WIP] switch: Use CLI::Parser to parse args switch: Use CLI::Parser to parse args Jan 20, 2019
@GauthamGoli GauthamGoli merged commit f4dff6b into Homebrew:master Jan 20, 2019
@lock lock bot added the outdated PR was locked due to age label Feb 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants