Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecations and cleanup #5598

Merged
merged 1 commit into from
Jan 27, 2019
Merged

Update deprecations and cleanup #5598

merged 1 commit into from
Jan 27, 2019

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jan 23, 2019 •
edited
Loading

  • Move odeprecated to odisabled
  • Remove odisabled
  • Enable automatic cleanup on install/reinstall/upgrade.

Don't merge until the next release will be 2.0.0.

Closes #4730

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 23, 2019
Closed
6 tasks
claui
claui reviewed Jan 23, 2019
View reviewed changes
Copy link
Contributor

@claui claui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on this once the failing test is removed.

@MikeMcQuaid
Update deprecations and cleanup
eed1444 
- Move `odeprecated` to `odisabled`
- Remove `odisabled`
- Enable automatic cleanup on install/reinstall/upgrade.
@MikeMcQuaid MikeMcQuaid changed the title Update deprecations Update deprecations and cleanup Jan 23, 2019
@MikeMcQuaid MikeMcQuaid merged commit 9b5ab7f into Homebrew:master Jan 27, 2019
@MikeMcQuaid MikeMcQuaid deleted the odeprecated-odisabled branch January 27, 2019 12:13
@rhanneken rhanneken mentioned this pull request Feb 5, 2019
Closed
5 tasks
@lock lock bot added the outdated PR was locked due to age label Feb 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@claui claui claui left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @claui