Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: no longer need openssl/curl HTTP mirrors. #5626

Merged
merged 1 commit into from
Jan 27, 2019
Merged

audit: no longer need openssl/curl HTTP mirrors. #5626

merged 1 commit into from
Jan 27, 2019

Conversation

MikeMcQuaid
Copy link
Member

Mavericks' curl can download these fine over HTTPS.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
audit: no longer need openssl/curl HTTP mirrors.
efd69b1 
Mavericks' `curl` can download these fine over HTTPS.
@MikeMcQuaid MikeMcQuaid merged commit 76b3c3d into Homebrew:master Jan 27, 2019
@MikeMcQuaid MikeMcQuaid deleted the audit-no-http branch January 27, 2019 20:37
ottnorml
ottnorml reviewed Jan 27, 2019
View reviewed changes
Library/Homebrew/dev-cmd/audit.rb
@@ -1122,20 +1122,9 @@ def self.curl_openssl_and_deps
end

def audit_urls
urls = [url] + mirrors

curl_openssl_or_deps = ResourceAuditor.curl_openssl_and_deps.include?(owner.name)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid curl_openssl_or_deps gets called in line 1137 and throws an undefined local variable or method error.

@ottnorml ottnorml mentioned this pull request Jan 27, 2019
Closed
5 tasks
@claui claui mentioned this pull request Jan 28, 2019
Merged
6 tasks
@lock lock bot added the outdated PR was locked due to age label Feb 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ottnorml ottnorml ottnorml left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @ottnorml