Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify test/vendor Gemfiles and bundler configuration. #5780

Merged
merged 6 commits into from
Feb 23, 2019

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Feb 21, 2019

Move all gems to vendor/bundle from vendor/bundle-standlone.

This makes a bit more sense than having e.g. rubocop in both files and getting duplicated, inconsistent Dependabot PRs with different versions.

Also:

  • utils/gems: silence bundle check output (missed in Bump rubocop from 0.64.0 to 0.65.0 in /Library/Homebrew/test #5768).

  • cleanup: run bundle clean (now that we cannot get Bundler to do it automatically as it'll clean up itself every time).

  • Have you followed the guidelines in our Contributing document?

  • Have you checked to ensure there aren't other open Pull Requests for the same change?

  • Have you added an explanation of what your changes do and why you'd like us to include them?

  • Have you written new tests for your changes? Here's an example.

  • Have you successfully run brew style with your changes locally?

  • Have you successfully run brew tests with your changes locally?


@sjackman
Copy link
Member

sjackman commented Feb 21, 2019

==> Downloading https://linuxbrew.bintray.com/bottles-portable-ruby/portable-ruby-2.3.7.x86_64_linux.bottle.tar.gz‌
==> Pouring portable-ruby-2.3.7.x86_64_linux.bottle.tar.gz‌
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- active_support/core_ext/object/blank (LoadError)‌
	from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.7/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/global.rb:10:in `<top (required)>'
	from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:21:in `require_relative'
	from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:21:in `<main>'
Service 'sut' failed to build: The command '/bin/sh -c HOMEBREW_NO_ANALYTICS=1 HOMEBREW_NO_AUTO_UPDATE=1 brew tap homebrew/core 	&& chown -R linuxbrew: /home/linuxbrew/.linuxbrew 	&& rm -rf ~/.cache' returned a non-zero code: 1‌

on Azure

@MikeMcQuaid MikeMcQuaid merged commit 6c55fe1 into Homebrew:master Feb 23, 2019
@MikeMcQuaid MikeMcQuaid deleted the tests-vendor-join-gemfile branch February 23, 2019 12:50
@lock lock bot added the outdated PR was locked due to age label Mar 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants