Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Keg-only :provided_by_macos dep okay on Linux #5830

Merged

Conversation

sjackman
Copy link
Member

@sjackman sjackman commented Mar 2, 2019

Disable this brew audit error on Linux:

* Dependency 'zlib' may be unnecessary as it is provided by macOS;
try to build this formula without it.
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Disable this brew audit error on Linux:
* Dependency 'zlib' may be unnecessary as it is provided by macOS;
try to build this formula without it.
@sjackman sjackman force-pushed the audit-provided-by-macos-on-linux branch from 16dec7f to 82da3b4 Compare March 2, 2019 21:30
@sjackman sjackman merged commit 6c78b26 into Homebrew:master Mar 2, 2019
@sjackman sjackman deleted the audit-provided-by-macos-on-linux branch March 2, 2019 22:03
@lock lock bot added the outdated PR was locked due to age label Apr 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant