Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: add uses_from_macos dependency ordering #6924

Merged
merged 1 commit into from
Jan 15, 2020
Merged

audit: add uses_from_macos dependency ordering #6924

merged 1 commit into from
Jan 15, 2020

Conversation

jonchang
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Brings uses_from_macos into the brew audit fold by checking that it

  1. comes after any depends_on statements
  2. is ordered like depends_on statements

@jonchang
Copy link
Contributor Author

Note that I wasn't able to deduplicate more code in rubocops/dependency_order.rb. I need to pass in a predicate to a more generalized function but there's something funky going on with how rubocop's node searcher macros are constructed and I can't figure out how to work around it.

@jonchang jonchang merged commit fc0777b into Homebrew:master Jan 15, 2020
@jonchang jonchang deleted the uses_from_macos_audit branch January 15, 2020 19:37
@jonchang
Copy link
Contributor Author

Thanks for the quick review!

@lock lock bot added the outdated PR was locked due to age label Feb 14, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants