Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: fix docker tag #7380

Merged
merged 1 commit into from Apr 17, 2020
Merged

workflows: fix docker tag #7380

merged 1 commit into from Apr 17, 2020

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Apr 17, 2020

https://github.com/Homebrew/brew/runs/595913492
#7379

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@dawidd6 dawidd6 merged commit e8d6265 into Homebrew:master Apr 17, 2020
@dawidd6 dawidd6 deleted the fix-docker-tag branch April 17, 2020 17:10
@sjackman
Copy link
Member

The first part homebrew of homebrew_sut is the name of the current working directory, translated to lower case. This PR implies that the current working directory is not /home/linuxbrew/.linuxbrew/Homebrew. Should it be?

@sjackman
Copy link
Member

Also, thanks for the fix, Dawid!

@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants