Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pr-upload command #7401

Merged
merged 1 commit into from Apr 20, 2020
Merged

Add pr-upload command #7401

merged 1 commit into from Apr 20, 2020

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Apr 20, 2020

As a replacement for brew test-bot --ci-upload and per suggestion on Slack.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
Copy link
Member

Looks good! Could you add a simple _spec.rb file (that just ensures the arguments can be parsed)?

@dawidd6 dawidd6 force-pushed the pr-upload branch 2 times, most recently from 0055318 to 377b520 Compare April 20, 2020 09:03
@MikeMcQuaid MikeMcQuaid merged commit c4fed07 into Homebrew:master Apr 20, 2020
@MikeMcQuaid
Copy link
Member

Thanks @dawidd6!

@sjackman
Copy link
Member

Yes, thank you, Dawid!

Opened PR #7406 to add argument --root-url needed by third party taps.

@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants