bintray: fix package creation

[bayandin]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

This PR fixes bintray package creation.

Also, it changes ::package_exists? to return boolean value instead of SystemCommand instance

Ref: Homebrew/homebrew-core#53304 (comment)

[MikeMcQuaid]

When did this break? Was it a particular PR or a change on Bintray's/our side? Thanks!

[MikeMcQuaid]

Suggested change

	stderr = e.output.select { |type,| type == :stderr }
	.map { |_, line| line }
	stderr = e.output
	.select { |type,| type == :stderr }
	.map { |_, line| line }

or, if it works:

Suggested change

	stderr = e.output.select { |type,| type == :stderr }
	.map { |_, line| line }
	stderr = e.output
	.select { |type,| type == :stderr }
	.values

[bayandin]

The second option won't work because .select { |type,| type == :stderr } returns an array.
Will create a PR with the first one

[bayandin]

When did this break? Was it a particular PR or a change on Bintray's/our side? Thanks!

I think we have never used API for package creation since it was added in #7236

Line 116 always raises an exception because package is undefined:

brew/Library/Homebrew/bintray.rb

Lines 115 to 119 in 1147106

	if !formula_packaged[formula_name] && !package_exists?(repo: bintray_repo, package: bintray_package)
	odebug "Creating package #{@bintray_org}/#{bintray_repo}/#{package}"
	create_package repo: bintray_repo, package: bintray_package
	formula_packaged[formula_name] = true
	end

[MikeMcQuaid]

I think we have never used API for package creation since it was added in #7236

Gotcha so basically: no-one has used brew pr-pull until now?

[bayandin]

no-one has used brew pr-pull until now?

No-one has used brew pr-pull for a new formula

[MikeMcQuaid]

Thanks @bayandin!

[bayandin]

Thanks @MikeMcQuaid!

But I didn't have a chance to apply your suggestions 🙄

[Bo98]

No-one has used brew pr-pull for a new formula

People have, but it turns out it doesn't fail pr-publish (which invokes pr-pull internally in the workflow) when it happens.

Volta worked fine (done via pr-pull directly - not pr-publish), but likely ran at least once through the Homebrew Bottles Jenkins job which will have created the package on Bintray.

[MikeMcQuaid]

But I didn't have a chance to apply your suggestions 🙄

Oops, sorry, misread this. What do you think of them?

[Bo98]

Interestingly, this doesn't work in the CI: https://github.com/Homebrew/homebrew-core/runs/618091933?check_suite_focus=true

Yet, I run pr-pull locally and it works fine.

Judging by the "Linuxbrew/2.2.13-138-gd5ab653", it seems to be the latest version so isn't an update issue.

[bayandin]

Hmm, interesting.

Can it be related to the curl version that we use? It seems it is 7.47.0 on the agent (took it from UA string)

[Bo98]

Ok so it fails to properly check if a package exists when you have the --verbose flag.

The logic here relies on --fail being passed, but that doesn't happen when show_output is true, which is the case for --verbose.

--fail being tied with show_output seems a bit weird to me.

[bayandin]

Yup, have found it as well, as was surprised too 😄

#7435 will fix it for now