Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gem to install gems instead of invoking system #7687

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

rmNULL
Copy link
Contributor

@rmNULL rmNULL commented Jun 4, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Performing a gem install using system when a ruby program is running,
for unknown reasons( i couldn't figure out) fails to require the newly installed gem.
However by performing Gem.install the newly installed gem can be required.

Example for previously failing case

Homebrew.install_gem! "hola"
require 'hola' fails with LoadError

Other Notes / Doubts

Shell out to gem to avoid RubyGems requires for e.g. loading JSON.

deleted comment, i would like to know what this meant.

@rmNULL rmNULL changed the title Use Gem to install gems instead of invoking system Use Gem to install gems instead of invoking system Jun 4, 2020
@MikeMcQuaid MikeMcQuaid merged commit fbad5fc into Homebrew:master Jun 4, 2020
@MikeMcQuaid
Copy link
Member

Thanks @rmNULL! I'm game for trying this but may need to revert if issues crop up.

@rmNULL rmNULL deleted the install_gem_without_system branch June 4, 2020 08:53
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants