New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENV: SDK can be nil #7694

Merged

MikeMcQuaid merged 1 commit into Homebrew:master from mistydemeo:fix_nil_sdk_check

Jun 5, 2020

Member

mistydemeo commented Jun 4, 2020 •

edited

Loading

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew tests with your changes locally?

On macOS versions before the CLT became an SDK, sdk will be nil here. We need to guard that check before calling methods on it.


          ENV: SDK can be nil

613c397

mistydemeo force-pushed the fix_nil_sdk_check branch from 4d464ff to 613c397 Compare

June 5, 2020 00:38

MikeMcQuaid merged commit 4479e04 into Homebrew:master

Member

MikeMcQuaid commented Jun 5, 2020

Thanks @mistydemeo!

mistydemeo deleted the fix_nil_sdk_check branch

June 5, 2020 17:02

BrewTestBot added the outdated label

Homebrew locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels