Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve errors reported by Sorbet #7764

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

vidusheeamoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Sorbet was reporting errors (error code: 4010) on the auto-generated tapioca RBI files. Since sorbet-typed has a good enough RBI for json hence we can exclude json from tapioca generation using the --exclude flag.

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes sense!

Can you please put the contents of the PR description in the first commit message, so that future us can look back not just through the PRs? Things like why you're excluding a file from Tapioca, and the specific --exclude command to run in the future.

You can amend a previous commit's message with:

git rebase -i master
# change `pick` to `reword` on the commit you want to reword
# exit the rebase editor (:wq in vim)
# reword your commit message to have the extra context as a separate paragraph
git push --force-with-lease # no-one except you has made any changes to your branch, but it's a nice hygenic thing

(If you're at all confused, let me know on Slack and we can screen share or something.)

Sorbet was reporting errors (error code: 4010) on the auto-generated tapioca RBI files.
Since sorbet-typed has a good enough RBI for json hence we can exclude json from tapioca generation using the --exclude flag.
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent git rebase! 👏

@issyl0 issyl0 merged commit 624efee into Homebrew:master Jun 17, 2020
@vidusheeamoli vidusheeamoli deleted the resolve-srb-errors branch June 18, 2020 13:27
@issyl0 issyl0 added the gsoc-outreachy Google Summer of Code or Outreachy label Jul 8, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 25, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 25, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gsoc-outreachy Google Summer of Code or Outreachy outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants