Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac/utils/bottles: support ARM bottles. #7815

Merged
merged 1 commit into from
Jun 24, 2020
Merged

os/mac/utils/bottles: support ARM bottles. #7815

merged 1 commit into from
Jun 24, 2020

Conversation

MikeMcQuaid
Copy link
Member

This will be eventually needed for Big Sur.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This will be eventually needed for Big Sur.
@MikeMcQuaid MikeMcQuaid merged commit fd72547 into Homebrew:master Jun 24, 2020
@MikeMcQuaid MikeMcQuaid deleted the arm_bottles branch June 24, 2020 15:22
@sjackman
Copy link
Member

On Linux (and generic) the order of this two-tuple is CPU_OS.

def tag
@tag ||= "#{ENV["HOMEBREW_PROCESSOR"]}_#{ENV["HOMEBREW_SYSTEM"]}".downcase.to_sym
end

Should macOS use this same order for consistency?

@MikeMcQuaid
Copy link
Member Author

I'm fine with whatever.

@sjackman
Copy link
Member

sjackman commented Jul 8, 2020

Opened PR #7942

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 25, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants