Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: set multiple files to true #8057

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

vidusheeamoli
Copy link
Contributor

@vidusheeamoli vidusheeamoli commented Jul 21, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Set the following files to true in sorbet/files.yaml:

  • ./fetch.rb
  • ./formula_pin.rb
  • ./hardware.rb
  • ./help.rb
  • ./language/go.rb
  • ./language/java.rb
  • ./language/perl.rb
  • ./messages.rb

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 🕵️‍♀️ work! How are you finding all of these that don't need RBI files? 😲

Library/Homebrew/sorbet/rbi/homebrew.rbi Outdated Show resolved Hide resolved
Set the following files to true in sorbet/files.yaml:
- ./fetch.rb
- ./formula_pin.rb
- ./hardware.rb
- ./help.rb
- ./language/go.rb
- ./language/java.rb
- ./language/perl.rb
- ./messages.rb
@issyl0 issyl0 merged commit 87628d3 into Homebrew:master Jul 22, 2020
@vidusheeamoli vidusheeamoli deleted the set-files-to-true branch July 22, 2020 17:47
@issyl0 issyl0 added the gsoc-outreachy Google Summer of Code or Outreachy label Jul 31, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gsoc-outreachy Google Summer of Code or Outreachy outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants