Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup Patchelf refinements, update patchelf to 1.2.0 in Gemfile.lock #8123

Merged
merged 2 commits into from Jul 29, 2020
Merged

cleanup Patchelf refinements, update patchelf to 1.2.0 in Gemfile.lock #8123

merged 2 commits into from Jul 29, 2020

Conversation

rmNULL
Copy link
Contributor

@rmNULL rmNULL commented Jul 28, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Resolves #8120

rmNULL
rmNULL commented Jul 28, 2020
View reviewed changes
Library/Homebrew/Gemfile.lock Outdated
@@ -141,4 +141,4 @@ DEPENDENCIES
simplecov

BUNDLED WITH
1.17.3
1.17.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know why this happened.
restore it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah revert this chunk.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1.17.2
1.17.3

Copy link
Member

@Bo98 Bo98 Jul 29, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundler which ships with Portable Ruby is 1.17.2. I'm not sure how 1.17.3 got here (is it different on Catalina system Ruby?) - it's been like that for a couple months judging by warnings spewed every time I update/install gems. I've just ignored it.

But that explains how it switched to 1.17.2 for you - it does the same thing for me on a default portable Ruby install.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 thanks that explains it 🥂

Library/Homebrew/Gemfile.lock
@@ -55,7 +55,7 @@ GEM
parallel
parser (2.7.1.4)
ast (~> 2.4.1)
patchelf (1.1.1)
patchelf (1.2.0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for this to work without refinements we need 1.2.0.
updating Gemfile(.lock) is a must

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been merged, you can rebase this.

@rmNULL
Copy link
Contributor Author

rmNULL commented Jul 28, 2020

cc @sjackman @woodruffw @MikeMcQuaid

sjackman
sjackman reviewed Jul 28, 2020
View reviewed changes
Library/Homebrew/os/linux/elf.rb
end
end
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

sjackman
sjackman suggested changes Jul 28, 2020
View reviewed changes
Library/Homebrew/Gemfile.lock Outdated
@@ -141,4 +141,4 @@ DEPENDENCIES
simplecov

BUNDLED WITH
1.17.3
1.17.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1.17.2
1.17.3

@rmNULL rmNULL requested a review from sjackman July 29, 2020 04:18
MikeMcQuaid
MikeMcQuaid approved these changes Jul 29, 2020
View reviewed changes
Library/Homebrew/Gemfile.lock
@@ -55,7 +55,7 @@ GEM
parallel
parser (2.7.1.4)
ast (~> 2.4.1)
patchelf (1.1.1)
patchelf (1.2.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been merged, you can rebase this.

Library/Homebrew/os/linux/elf.rb
end
end
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MikeMcQuaid MikeMcQuaid merged commit 126e4c9 into Homebrew:master Jul 29, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @rmNULL!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@sjackman sjackman Awaiting requested review from sjackman

Assignees

@sjackman sjackman

@rmNULL rmNULL

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executing brew --repo homebrew/core causes bundler gems installation
5 participants
@rmNULL @MikeMcQuaid @sjackman @Bo98 @BrewTestBot