Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various: update CI links. #816

Merged
merged 4 commits into from
Aug 26, 2016
Merged

various: update CI links. #816

merged 4 commits into from
Aug 26, 2016

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Aug 26, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot BrewTestBot added the in progress Maintainers are working on this label Aug 26, 2016
@@ -773,7 +773,7 @@ def test_pull
end

assert_match "Testing URLs require `--bottle`!",
cmd_fail("pull", "http://bot.brew.sh/job/Homebrew\%20Testing/1028/")
cmd_fail("pull", "https://bot.brew.sh/job/Homebrew\%20Testing/1028/")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this build isn't in the jenkins cache anymore

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command will still fail, but I think for the wrong reason?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a placeholder, it could point to anything in the testing section, even something that doesn't exist:

~> brew pull https://bot.brew.sh/job/Homebrew\%20Testing/9999/
Error: Testing URLs require `--bottle`!

I'm only really updating it to https for the sake of consistency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@DomT4 DomT4 merged commit 00bb1f2 into Homebrew:master Aug 26, 2016
@BrewTestBot BrewTestBot removed the in progress Maintainers are working on this label Aug 26, 2016
@DomT4 DomT4 deleted the httpsbot branch August 26, 2016 02:29
@MikeMcQuaid
Copy link
Member

Cheers!

@DomT4 DomT4 mentioned this pull request Aug 29, 2016
4 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants