-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various: update CI links. #816
Conversation
@@ -773,7 +773,7 @@ def test_pull | |||
end | |||
|
|||
assert_match "Testing URLs require `--bottle`!", | |||
cmd_fail("pull", "http://bot.brew.sh/job/Homebrew\%20Testing/1028/") | |||
cmd_fail("pull", "https://bot.brew.sh/job/Homebrew\%20Testing/1028/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this build isn't in the jenkins cache anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The command will still fail, but I think for the wrong reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a placeholder, it could point to anything in the testing section, even something that doesn't exist:
~> brew pull https://bot.brew.sh/job/Homebrew\%20Testing/9999/
Error: Testing URLs require `--bottle`!
I'm only really updating it to https
for the sake of consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation!
Cheers! |
brew tests
with your changes locally?