Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecate! and disable! message #8549

Merged
merged 1 commit into from Aug 31, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Aug 31, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow up to #8530

Fixes an issue where the wrong message is displayed

Before this PR:

$ brew install tj
Error: tj has been disabled because it {:does_not_build=>"does not build", :no_license=>"has no license", :repo_archived=>"has an archived upstream repository", :repo_removed=>"has a removed upstream repository", :unmaintained=>"is not maintained upstream", :unsupported=>"is not supported upstream", :deprecated_upstream=>"is deprecated upstream", :versioned_formula=>"is a versioned formula"}!

After:

$ brew install tj
Error: tj has been disabled because it has no license!

CC: @SeekingMeaning

@Rylan12 Rylan12 mentioned this pull request Aug 31, 2020
6 tasks
@reitermarkus
Copy link
Member

Nitpick: Why is “it” not part of the reason? That way it would also read like a sentence inside of formulae.

@Rylan12
Copy link
Member Author

Rylan12 commented Aug 31, 2020

Nitpick: Why is “it” not part of the reason? That way it would also read like a sentence inside of formulae.

It turned out that almost all descriptions started with it so it was added to the message by default to remove the need for typing it every time. See Homebrew/homebrew-core#60321 (comment)

With the new symbols, most reasons should be something like disable! because: :unmaintained or similar which removes the need for it at all. It's only an issue when you need to provide a custom description. There is also a style check for it so it's not accidentally added twice.

@MikeMcQuaid MikeMcQuaid merged commit 94eb2ad into Homebrew:master Aug 31, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @Rylan12!

@Rylan12 Rylan12 deleted the disable-message-fix-again branch August 31, 2020 18:44
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants