Fix disable and deprecate reasons#8530
Merged
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom Aug 31, 2020
Rylan12:fix-disable-and-deprecate-reasons
Merged
Fix disable and deprecate reasons#8530MikeMcQuaid merged 3 commits intoHomebrew:masterfrom Rylan12:fix-disable-and-deprecate-reasons
MikeMcQuaid merged 3 commits intoHomebrew:masterfrom
Rylan12:fix-disable-and-deprecate-reasons
Conversation
Member
Author
|
This PR is blocked by #8533. Once #8533 has been merged, this can be rebased on to master (and will need to drop f2b02487dc705762899468700094e4a276b23015). This will still need to wait on Homebrew/homebrew-core#60321 and Homebrew/homebrew-core#60336 to be merged into homebrew-core and linuxbrew-core before this will be good to go, though. |
dtrodrigues
reviewed
Aug 30, 2020
Member
|
Thanks again @Rylan12! |
Member
Author
|
Oops, you're right, @SeekingMeaning. Good catch! (could have sworn I tested it...). I'll get a fix up soon Edit: fix in #8549 |
This was referenced Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?Follow up to #8512
This PR does several things:
brew stylewould interpretbecause:asdate:disable!in addition todeprecatebecause:string to make sure that:it.,!or?itbefore the reasondisable!anddeprecate!Now, both of the following are supported:
Here is the list of symbols and their corresponding strings that I added in this PR (of course, these can be changed as needed):
:does_not_build: does not build:no_license: has no license:repo_archived: has an archived upstream repository:repo_removed: has a removed upstream repository:unmaintained: is not maintained upstream:unsupported: is not supported upstream:deprecated_upstream: is deprecated upstream:versioned_formula: is a versioned formula