Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: migrate to GitHub Container Registry. #8569

Merged
merged 1 commit into from Sep 3, 2020

Conversation

MikeMcQuaid
Copy link
Member

This seems a better fit for us (unauthenticated anonymous access) than GitHub Packages Docker registry was.

Followed steps on https://docs.github.com/en/packages/getting-started-with-github-container-registry/migrating-to-github-container-registry-for-docker-images

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
Copy link
Member Author

@sjackman @jonchang This won't actually push any changes as-is until tagged or on the master branch. Will merge when you're 👍🏻 and fix/revert depending on the master builds. Might be nice to get this in for 2.5.0 so we can announce it there.

Copy link
Member

@sjackman sjackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/packages/getting-started-with-github-container-registry/migrating-to-github-container-registry-for-docker-images#domain-changes

docker.pkg.github.com/OWNER/REPOSITORY/IMAGE_NAME
ghcr.io/OWNER/IMAGE_NAME

Notice that it's not ghcr.io/OWNER/REPOSITORY/IMAGE_NAME but instead ghcr.io/OWNER/IMAGE_NAME, so ghcr.io/homebrew/brew/… needs to change to ghcr.io/homebrew/… throughout.

@maxim-belkin
Copy link
Member

It also needs a new PAT as it can't use GITHUB_TOKEN:

GitHub Container Registry does not support using GITHUB_TOKEN for your PAT so you must use a different custom variable, such as CR_PAT. For more information, see "Creating and storing encrypted secrets."

@MikeMcQuaid
Copy link
Member Author

Notice that it's not ghcr.io/OWNER/REPOSITORY/IMAGE_NAME but instead ghcr.io/OWNER/IMAGE_NAME, so ghcr.io/homebrew/brew/… needs to change to ghcr.io/homebrew/… throughout.

Done!

This seems a better fit for us (unauthenticated anonymous access) than
GitHub Packages Docker registry was.

Followed steps on:
https://docs.github.com/en/packages/getting-started-with-github-container-registry/migrating-to-github-container-registry-for-docker-images
@MikeMcQuaid
Copy link
Member Author

It also needs a new PAT as it can't use GITHUB_TOKEN

Done!

@MikeMcQuaid MikeMcQuaid merged commit 5875ffa into master Sep 3, 2020
@MikeMcQuaid MikeMcQuaid deleted the github-container-registry branch September 3, 2020 09:04
@MikeMcQuaid
Copy link
Member Author

Let's see how this goes 🤞🏻

@MikeMcQuaid
Copy link
Member Author

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants