Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use monochrome ✔, which works better with filter #8655

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Use monochrome ✔, which works better with filter #8655

merged 1 commit into from
Sep 8, 2020

Conversation

claui
Copy link
Contributor

@claui claui commented Sep 8, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Addresses #8627 (comment).

grafik

@claui claui requested a review from Rylan12 September 8, 2020 18:01
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm not sure having any checkmark really adds anything to the description, but I'm not opposed to it.

@claui claui merged commit 455965d into Homebrew:master Sep 8, 2020
@claui claui deleted the fix-✅ branch September 8, 2020 20:09
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants