Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: add missing header param to url class #9001

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

tie624
Copy link
Contributor

@tie624 tie624 commented Oct 27, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

The header param was missing from the URL class.

I got an error while trying to use the header param according to the docs: https://github.com/Homebrew/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/url.md

This fixed the error for me.

I didn't write any tests since I couldn't find an existing spec file for this.

@MikeMcQuaid MikeMcQuaid requested review from reitermarkus and vitorgalvao and removed request for reitermarkus October 28, 2020 08:27
@MikeMcQuaid MikeMcQuaid added the cask Homebrew Cask label Oct 28, 2020
@MikeMcQuaid MikeMcQuaid requested review from a team and removed request for vitorgalvao October 28, 2020 08:27
@miccal
Copy link
Member

miccal commented Oct 28, 2020

Looks good, thank you @tie624.

@MikeMcQuaid
Copy link
Member

@miccal If you're 👍🏻 you can ✅ and merge as desired.

@miccal miccal merged commit 771c961 into Homebrew:master Oct 28, 2020
@MikeMcQuaid
Copy link
Member

Thanks @tie624 and thanks @miccal for the review and merge.

@tie624 tie624 deleted the fix_url_missing_param branch November 10, 2020 22:40
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants