Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update display of requirements #9021

Merged
merged 5 commits into from
Nov 2, 2020

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Update how requirements are displayed in brew info [--json], when calling their inspect() methods, and their error messages when they aren't met. I added capitalization and version numbers where possible to distinguish them from formula names at a glance.

@MikeMcQuaid MikeMcQuaid merged commit d6d38e3 into Homebrew:master Nov 2, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @EricFromCanada!

@EricFromCanada EricFromCanada deleted the requirements-display branch November 2, 2020 14:57
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 3, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants